Support app command contexts #9406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izxxr
suggested changes
May 14, 2023
Rapptz
requested changes
May 14, 2023
There was a problem hiding this comment.
Thanks for the PR.
Just some minor bikeshedding/comments for the first pass:
AppCommandContextis not an enum, it's actually a flag type. Discord has recently been doing bitfields using an array because they falsely believe it leads to better developer experience since they are targeting developers that do not know how to bitshift. I suggest migrating this over to use the newArrayFlagstype and work with it. I have tried to get them to change this to a regular integer but they seem to want to not want to change it to the more space-efficient and sane format.allowed_contextsand any external reference tocontextin this well context should probably be calledrestrictinstead. The type should still be calledAppCommandContextbut the attribute (and maybe eventual decorator) should be calledrestrict.private_onlyshould probably be renamed toprivate_channel_onlyfor consistency with the library (e.g.abc.PrivateChannel).- The flag names for
AppCommandContextshould not use the Discord naming scheme since they are bad, instead it should probably beguild,dm_channel, andprivate_channel.
Rapptz
requested changes
May 15, 2023
owocado
suggested changes
May 17, 2023
Rapptz
added
the
pending
Gobot1234
reviewed
Mar 18, 2024
| @@ -2430,6 +2473,135 @@ def inner(f: T) -> T: | |||
| return inner(func) | |||
|
|
|||
|
|
|||
| def private_channel_only(func: Optional[T] = None) -> Union[T, Callable[[T], T]]: | |||
There was a problem hiding this comment.
This should either drop the ability to optionally use parens or add the necessary overloads here otherwise you'll get type errors.
Zalk0
reviewed
Mar 19, 2024
| .. code-block:: python3 | ||
|
|
||
| @app_commands.command() | ||
| @app_commands.allow_contexts(guilds=False, dms=False, private_channels=True) |
There was a problem hiding this comment.
Suggested change
| @app_commands.allow_contexts(guilds=False, dms=False, private_channels=True) | |
| @app_commands.allow_contexts(guilds=True, dms=False, private_channels=True) |
Didn't you want to set guilds to True in the example as that's what you say in the response message just below
6 tasks
|
Superseded by #9760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
@dm_onlyand@private_onlydecorators to allow specifying the newcontextsfield in app commands, as specified here, as well as the relevant init args.The docs mention that if this field is specified, the permission calculation ignores the
dm_permissionfield. Not sure how this should be reflected in the library for backwards compatibility purposes.Checklist